Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: <hr> in blog hidden behind offset figure #310

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Feb 21, 2024

Overview

On the blog, do not let <hr /> be hidden behind offset/floated content.

Note

Fixed on production TUP via temporary snippet, and tested on recent black history spotlight month article.

Related

Changes

  • added CSS

Testing

  1. Find/Create a blog post.
  2. Have/Add Bootstrap 4 Picture that is aligned right.
  3. Have/Add Paragraph(s) long enough to go beneath image.
  4. Have/Add an <hr> among the paragraphs.
  5. Verify <hr> stops before touching image.
Screenshots
  1. 1
  2. 2
  3. 3
  4. 4

UI

Before After
hr float bug - before hr float bug - after

@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Feb 21, 2024
@wesleyboar wesleyboar changed the title hotfix: <hr> in blog hidden behidn offset figure hotfix: <hr> in blog hidden behind offset figure Feb 22, 2024
@wesleyboar wesleyboar added the patch A backward-compatible fix label Feb 22, 2024
@wesleyboar wesleyboar merged commit 93db791 into main Mar 1, 2024
@wesleyboar wesleyboar deleted the hotfix/blog-hr-hidden-behind-offset-image branch March 1, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants